HomeWork - Добавлен RxJava2#216
Open
BambinoGrandi wants to merge 1 commit intoOtus-Android:masterfrom
Open
Conversation
| ) | ||
| } | ||
|
|
||
| fun onDestroy() { |
There was a problem hiding this comment.
onDestroy() метод Activity/Fragment. ViewModel должен переопределять onCleared(), который вызывается системой при уничтожении VM. onDestroy() в VM не вызывается автоматически, поэтому подписки не отписываются, что приводит к утечкам памяти
override fun onCleared() {
super.onCleared()
disposable.clear()
}
| _catsLiveData.value = ServerError | ||
| } | ||
| }) | ||
| private fun error(error: Throwable) { |
There was a problem hiding this comment.
Метод создает объект Error, но не устанавливает его в _catsLiveData. Наши подписки при ошибке на UI не получает уведомление.
_catsLiveData.value = Error...
| } | ||
|
|
||
| override fun onDestroy() { | ||
| catsViewModel.onDestroy() |
There was a problem hiding this comment.
Когда вы поправите VM, onCleared() вызывается системой автоматически при уничтожении ViewModel, вызывать его вручную не нужно
Эту строку надо будет просто убрать
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание